* [Cluster-devel] [PATCH] fence_xvm: Fix incorrect success return codes
@ 2012-07-25 14:43 Ryan McCabe
2012-07-25 14:50 ` Lon Hohberger
0 siblings, 1 reply; 2+ messages in thread
From: Ryan McCabe @ 2012-07-25 14:43 UTC (permalink / raw)
To: cluster-devel.redhat.com
This patch fixes two places where fence_xvm will return success
for fencing operations when fencing has failed due to the
challenge/response failing.
Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
---
fence/agents/xvm/fence_xvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fence/agents/xvm/fence_xvm.c b/fence/agents/xvm/fence_xvm.c
index d1ffb12..eb006fd 100644
--- a/fence/agents/xvm/fence_xvm.c
+++ b/fence/agents/xvm/fence_xvm.c
@@ -99,14 +99,14 @@ tcp_exchange(int fd, fence_auth_type_t auth, void *key,
if (tcp_challenge(fd, auth, key, key_len, timeout) <= 0) {
/* Challenge failed */
printf("Invalid response to challenge\n");
- return 0;
+ return 1;
}
/* Now they'll send us one, so we need to respond here */
dbg_printf(3, "Responding to TCP challenge\n");
if (tcp_response(fd, auth, key, key_len, timeout) <= 0) {
printf("Invalid response to challenge\n");
- return 0;
+ return 1;
}
dbg_printf(2, "TCP Exchange + Authentication done... \n");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-25 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-25 14:43 [Cluster-devel] [PATCH] fence_xvm: Fix incorrect success return codes Ryan McCabe
2012-07-25 14:50 ` Lon Hohberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).