From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 10 Sep 2012 11:43:37 -0400 Subject: [Cluster-devel] [PATCH] dlm: check the maximum size of a request from user In-Reply-To: <1347200218-3697-1-git-send-email-levinsasha928@gmail.com> References: <1347200218-3697-1-git-send-email-levinsasha928@gmail.com> Message-ID: <20120910154337.GA1474@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sun, Sep 09, 2012 at 04:16:58PM +0200, Sasha Levin wrote: > device_write only checks whether the request size is big enough, but it doesn't > check if the size is too big. > > At that point, it also tries to allocate as much memory as the user has requested > even if it's too much. This can lead to OOM killer kicking in, or memory corruption > if (count + 1) overflows. thanks, pushed to next