From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Mon, 28 Jan 2013 10:57:23 -0500 Subject: [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all() In-Reply-To: <1359163872-1949-11-git-send-email-tj@kernel.org> References: <1359163872-1949-1-git-send-email-tj@kernel.org> <1359163872-1949-11-git-send-email-tj@kernel.org> Message-ID: <20130128155723.GC16789@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jan 25, 2013 at 05:31:08PM -0800, Tejun Heo wrote: > idr_destroy() can destroy idr by itself and idr_remove_all() is being > deprecated. > > The conversion isn't completely trivial for recover_idr_clear() as > it's the only place in kernel which makes legitimate use of > idr_remove_all() w/o idr_destroy(). Replace it with idr_remove() call > inside idr_for_each_entry() loop. It goes on top so that it matches > the operation order in recover_idr_del(). > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Christine Caulfield > Cc: David Teigland > Cc: cluster-devel at redhat.com > --- > This patch depends on an earlier idr patch and given the trivial > nature of the patch, I think it would be best to route these together > through -mm. Please holler if there's any objection. Yes, that's good for me. I'll grab the set and test the dlm bits.