From: Tejun Heo <tj@kernel.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()
Date: Mon, 4 Feb 2013 09:44:55 -0800 [thread overview]
Message-ID: <20130204174455.GP27963@mtj.dyndns.org> (raw)
In-Reply-To: <510F2D86.5050408@huawei.com>
Hey, Li.
On Mon, Feb 04, 2013 at 11:39:50AM +0800, Li Zefan wrote:
> > Fix it by ensuring proceeding to the next slot doesn't carry over the
> > unaligned offset - ie. use round_up(id + 1, slot_distance) instead of
> > id += slot_distance.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
>
> Don't we need to cc stable?
I thought we didn't have idr_remove() inside idr_for_each_entry() in
kernel, which isn't true. drbd already does that, so yeah, we need to
cc stable.
Thanks.
--
tejun
prev parent reply other threads:[~2013-02-04 17:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359163872-1949-1-git-send-email-tj@kernel.org>
2013-01-26 1:31 ` [Cluster-devel] [PATCH 09/14] dlm: use idr_for_each_entry() in recover_idr_clear() error path Tejun Heo
2013-01-28 15:55 ` David Teigland
2013-01-26 1:31 ` [Cluster-devel] [PATCH 10/14] dlm: don't use idr_remove_all() Tejun Heo
2013-01-28 15:57 ` David Teigland
2013-01-29 15:13 ` David Teigland
2013-01-30 21:24 ` David Teigland
2013-01-31 23:53 ` Tejun Heo
2013-02-01 0:18 ` Tejun Heo
2013-02-01 17:44 ` David Teigland
2013-02-01 18:00 ` Tejun Heo
2013-02-02 23:10 ` [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next() Tejun Heo
2013-02-02 23:11 ` Tejun Heo
2013-02-03 2:15 ` Randy Dunlap
2013-02-03 17:53 ` Hugh Dickins
2013-02-05 15:36 ` David Teigland
2013-02-04 3:39 ` Li Zefan
2013-02-04 17:44 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204174455.GP27963@mtj.dyndns.org \
--to=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).