From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tejun Heo <tj@kernel.org>
Date: Mon, 4 Feb 2013 09:44:55 -0800
Subject: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next()
In-Reply-To: <510F2D86.5050408@huawei.com>
References: <1359163872-1949-11-git-send-email-tj@kernel.org>
	<20130128155723.GC16789@redhat.com>
	<20130129151317.GA11609@redhat.com>
	<20130130212417.GJ24014@redhat.com>
	<20130131235320.GN6824@mtj.dyndns.org>
	<20130201001841.GP6824@mtj.dyndns.org>
	<20130201174443.GC3812@redhat.com>
	<20130201180028.GC31863@mtj.dyndns.org>
	<20130202231048.GA3940@mtj.dyndns.org>
	<510F2D86.5050408@huawei.com>
Message-ID: <20130204174455.GP27963@mtj.dyndns.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hey, Li.

On Mon, Feb 04, 2013 at 11:39:50AM +0800, Li Zefan wrote:
> > Fix it by ensuring proceeding to the next slot doesn't carry over the
> > unaligned offset - ie. use round_up(id + 1, slot_distance) instead of
> > id += slot_distance.
> > 
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> 
> Don't we need to cc stable?

I thought we didn't have idr_remove() inside idr_for_each_entry() in
kernel, which isn't true.  drbd already does that, so yeah, we need to
cc stable.

Thanks.

-- 
tejun