From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Tue, 5 Feb 2013 10:36:14 -0500 Subject: [Cluster-devel] [PATCH] idr: fix a subtle bug in idr_get_next() In-Reply-To: <20130202231135.GB3940@mtj.dyndns.org> References: <1359163872-1949-11-git-send-email-tj@kernel.org> <20130128155723.GC16789@redhat.com> <20130129151317.GA11609@redhat.com> <20130130212417.GJ24014@redhat.com> <20130131235320.GN6824@mtj.dyndns.org> <20130201001841.GP6824@mtj.dyndns.org> <20130201174443.GC3812@redhat.com> <20130201180028.GC31863@mtj.dyndns.org> <20130202231048.GA3940@mtj.dyndns.org> <20130202231135.GB3940@mtj.dyndns.org> Message-ID: <20130205153614.GA1508@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Feb 02, 2013 at 03:11:35PM -0800, Tejun Heo wrote: > On Sat, Feb 02, 2013 at 03:10:48PM -0800, Tejun Heo wrote: > > Fix it by ensuring proceeding to the next slot doesn't carry over the > > unaligned offset - ie. use round_up(id + 1, slot_distance) instead of > > id += slot_distance. > > > > Signed-off-by: Tejun Heo > > Reported-by: David Teigland > > Cc: KAMEZAWA Hiroyuki > > David, can you please test whether the patch makes the skipped > deletion bug go away? Yes, I've tested, and it works fine now. Thanks, Dave