From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Thu, 6 Jun 2013 18:53:12 +0100 Subject: [Cluster-devel] GFS2: Add atomic_open support In-Reply-To: <1370530212.2744.34.camel@menhir> References: <1370530212.2744.34.camel@menhir> Message-ID: <20130606175312.GG13110@ZenIV.linux.org.uk> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jun 06, 2013 at 03:50:12PM +0100, Steven Whitehouse wrote: > > The following patch implements atomic_open for GFS2. This is mostly > straightforward, however there is one corner case which I've had to > deal with, beyond what would normally be expected for a local > filesystem. Broken - what will happen if you hit a symlink, for starters? On everything handled locally you should just return finish_no_open(file, dentry) and let the caller deal with that; the only cases that might make sense to handle in ->atomic_open() are regular files and directories. For gfs2 it should be just regular files. While we are at it, do you even need ->private_data for gfs2 directories?