From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/0] Consolidate Posix ACL implementation V3
Date: Fri, 20 Dec 2013 05:11:12 -0800 [thread overview]
Message-ID: <20131220131112.955655330@bombadil.infradead.org> (raw)
This series consolidates the various cut'n'pasted Posix ACL implementations
into a single common one based on the ->get_acl method Linus added a while
ago and a new ->set_acl counterpart.
This remove ~1800 lines of code and provides a single place to implement
various nasty little gems of the semantics.
Unfortunately the 9p code is still left out - it implements the ACLs
in two very weird ways, one using the common code but on the client only,
and one pasing things straight through to the server. We could easily
convert it to the new code on the write side if ->set_acl took a dentry,
but there's no cance to do that on the ->get_acl side. Ideas how to
handle it welcome.
After that we'd be ready to never go into the fs for the ACL attributes
and branch straight to the ACL code below the syscall, repairing the
old API braindamage of overloading ACLs onto the xattrs.
Changes from V2:
- remove redundant S_ISLNK checks
- fix the get_acl return value
- remove spurious symlink get_acl instance in gfs2
- fix default ACL inheritance on NFS
- use get_acl and set_acl from the NFS server
- remove some incorrectly copy&pasted code in hfsplus
Changes from V1:
- check for symlinks in the ACL code and remove checks in the lower
level functions.
- remove get_acl instances for symlinks in a few filesystems
- pass a umode_t mode argument to posix_acl_chmod to accomodate f2fs
- various cosemtic bits from the reviews.
Note that I still haven't heard from ocfs2 folks, so the patch is left
unchanged.
reply other threads:[~2013-12-20 13:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220131112.955655330@bombadil.infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).