cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Josh Triplett <josh@joshtriplett.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c
Date: Sun, 9 Feb 2014 05:04:56 -0800	[thread overview]
Message-ID: <20140209130456.GA30767@leaf> (raw)
In-Reply-To: <00380d95bfae6200d6120f050540236dbd1fc99b.1391949868.git.rashika.kheria@gmail.com>

On Sun, Feb 09, 2014 at 06:19:17PM +0530, Rashika Kheria wrote:
> Include appropriate header file fs/dlm/ast.h in fs/dlm/ast.c because it
> contains function prototypes of some functions defined in fs/dlm/ast.c.
> 
> This also eliminates the following warning in fs/dlm/ast:
> fs/dlm/ast.c:52:5: warning: no previous prototype for ?dlm_add_lkb_callback? [-Wmissing-prototypes]
> fs/dlm/ast.c:113:5: warning: no previous prototype for ?dlm_rem_lkb_callback? [-Wmissing-prototypes]
> fs/dlm/ast.c:174:6: warning: no previous prototype for ?dlm_add_cb? [-Wmissing-prototypes]
> fs/dlm/ast.c:212:6: warning: no previous prototype for ?dlm_callback_work? [-Wmissing-prototypes]
> fs/dlm/ast.c:267:5: warning: no previous prototype for ?dlm_callback_start? [-Wmissing-prototypes]
> fs/dlm/ast.c:278:6: warning: no previous prototype for ?dlm_callback_stop? [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ?dlm_callback_suspend? [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ?dlm_callback_resume? [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

>  fs/dlm/ast.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/dlm/ast.c b/fs/dlm/ast.c
> index 0e90f0c..42794c0 100644
> --- a/fs/dlm/ast.c
> +++ b/fs/dlm/ast.c
> @@ -14,6 +14,7 @@
>  #include "dlm_internal.h"
>  #include "lock.h"
>  #include "user.h"
> +#include "ast.h"
>  
>  static uint64_t dlm_cb_seq;
>  static DEFINE_SPINLOCK(dlm_cb_seq_spin);
> -- 
> 1.7.9.5
> 



  reply	other threads:[~2014-02-09 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b572932c3e016c55e596686283036316a1aacd2f.1391949868.git.rashika.kheria@gmail.com>
2014-02-09 12:49 ` [Cluster-devel] [PATCH 02/21] fs: Include appropriate header file in dlm/ast.c Rashika Kheria
2014-02-09 13:04   ` Josh Triplett [this message]
2014-02-09 13:10 ` [Cluster-devel] [PATCH 10/21] fs: Mark functions as static in gfs2/rgrp.c Rashika Kheria
2014-02-10 12:30   ` Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140209130456.GA30767@leaf \
    --to=josh@joshtriplett.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).