From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type
Date: Wed, 23 Jul 2014 13:33:32 -0500 [thread overview]
Message-ID: <20140723183332.GA21992@redhat.com> (raw)
In-Reply-To: <20140723141139.2cf90cb0@tlielax.poochiereds.net>
On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote:
> On Sun, 20 Jul 2014 11:23:43 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > op->info.rv is an s32, but it's only used as a u8.
> >
>
> I don't understand this patch. info.rv is s32 (and I assume that "rv"
> stands for "return value"). What I don't get is why you think it's just
> used as a u8. It seems to be used more like a bool than anything else,
Thank you, Jeff.
/* info.rv from userspace is 1 for conflict, 0 for no-conflict,
-ENOENT if there are no locks on the file */
rv = op->info.rv;
> and I'm not sure that "type" is really a good description for it. Maybe
> it should be a "bool" and named "conflict", given the comments in
> dlm_posix_get ?
type is not a good name.
Sorry Joe, I'm not a fan of your patches.
Dave
next prev parent reply other threads:[~2014-07-23 18:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 18:23 [Cluster-devel] [PATCH 0/9] fs.h/dlm: Neatening and argument removals Joe Perches
2014-07-20 18:23 ` [Cluster-devel] [PATCH 6/9] dlm: plock: Add argument descriptions to notify Joe Perches
2014-07-20 18:23 ` [Cluster-devel] [PATCH 7/9] dlm: fs: Remove unused conf from lm_grant Joe Perches
2014-07-23 18:00 ` Jeff Layton
2014-07-20 18:23 ` [Cluster-devel] [PATCH 8/9] dlm: plock: Reduce indentation by rearranging order Joe Perches
2014-07-23 18:01 ` Jeff Layton
2014-07-20 18:23 ` [Cluster-devel] [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type Joe Perches
2014-07-23 18:11 ` Jeff Layton
2014-07-23 18:33 ` David Teigland [this message]
2014-07-24 3:53 ` Joe Perches
2014-07-24 16:24 ` Jeff Layton
2014-07-24 16:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723183332.GA21992@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).