From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sat, 23 Aug 2014 18:27:57 -0700 Subject: [Cluster-devel] [PATCH 03/10] locks: generic_delete_lease doesn't need a file_lock at all In-Reply-To: <1408804878-1331-4-git-send-email-jlayton@primarydata.com> References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com> <1408804878-1331-4-git-send-email-jlayton@primarydata.com> Message-ID: <20140824012757.GA21609@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Sat, Aug 23, 2014 at 10:41:11AM -0400, Jeff Layton wrote: > +static int generic_delete_lease(struct file *filp) > { > struct file_lock *fl, **before; > struct dentry *dentry = filp->f_path.dentry; > struct inode *inode = dentry->d_inode; > > - trace_generic_delete_lease(inode, *flp); > - Can you keep the tracepoint and modify it to not need the file_lock pointer? It really helped me with some debugging lately. Otherwise looks fine, Reviewed-by: Christoph Hellwig