From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 02/10] nfsd: fix potential lease memory leak in nfs4_setlease
Date: Sun, 24 Aug 2014 08:48:39 -0700 [thread overview]
Message-ID: <20140824154839.GB15908@infradead.org> (raw)
In-Reply-To: <1408804878-1331-3-git-send-email-jlayton@primarydata.com>
On Sat, Aug 23, 2014 at 10:41:10AM -0400, Jeff Layton wrote:
> It's unlikely to ever occur, but if there were already a lease set on
> the file then we could end up getting back a different pointer on a
> successful setlease attempt than the one we allocated. If that happens,
> the one we allocated could leak.
>
> In practice, I don't think this will happen due to the fact that we only
> try to set up the lease once per nfs4_file, but this error handling is a
> bit more correct given the current lease API.
>
> Cc: J. Bruce Fields <bfields@fieldses.org>
> Signed-off-by: Jeff Layton <jlayton@primarydata.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2014-08-24 15:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-23 14:41 [Cluster-devel] [PATCH 00/10] locks/nfsd: internal lease API overhaul Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] [PATCH 01/10] locks: close potential race in lease_get_mtime Jeff Layton
2014-08-24 15:48 ` Christoph Hellwig
2014-08-25 20:01 ` J. Bruce Fields
2014-08-23 14:41 ` [Cluster-devel] [PATCH 02/10] nfsd: fix potential lease memory leak in nfs4_setlease Jeff Layton
2014-08-24 15:48 ` Christoph Hellwig [this message]
2014-08-23 14:41 ` [Cluster-devel] [PATCH 03/10] locks: generic_delete_lease doesn't need a file_lock at all Jeff Layton
2014-08-24 1:27 ` Christoph Hellwig
2014-08-24 10:09 ` Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] [PATCH 04/10] locks: clean up vfs_setlease kerneldoc comments Jeff Layton
2014-08-24 15:51 ` Christoph Hellwig
2014-08-25 20:11 ` J. Bruce Fields
2014-08-23 14:41 ` [Cluster-devel] [PATCH 05/10] nfsd: don't keep a pointer to the lease in nfs4_file Jeff Layton
2014-08-24 15:51 ` Christoph Hellwig
2014-08-23 14:41 ` [Cluster-devel] [PATCH 06/10] locks: plumb an "aux" pointer into the setlease routines Jeff Layton
2014-08-24 1:33 ` Christoph Hellwig
2014-08-24 10:08 ` Jeff Layton
2014-08-24 15:54 ` Christoph Hellwig
2014-08-25 20:28 ` J. Bruce Fields
2014-08-26 10:53 ` Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] [PATCH 07/10] locks: define a lm_setup handler for leases Jeff Layton
2014-08-24 15:58 ` Christoph Hellwig
2014-08-25 1:19 ` Jeff Layton
2014-08-26 13:58 ` Christoph Hellwig
2014-08-23 14:41 ` [Cluster-devel] [PATCH 08/10] locks: move i_lock acquisition into generic_*_lease handlers Jeff Layton
2014-08-24 16:06 ` Christoph Hellwig
2014-08-24 16:11 ` Christoph Hellwig
2014-08-31 14:51 ` Jeff Layton
2014-08-25 1:36 ` Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] [PATCH 09/10] locks: move freeing of leases outside of i_lock Jeff Layton
2014-08-24 16:08 ` Christoph Hellwig
2014-08-25 1:35 ` Jeff Layton
2014-08-23 14:41 ` [Cluster-devel] [PATCH 10/10] locks: update Documentation/filesystems with lease API changes Jeff Layton
2014-08-24 16:10 ` [Cluster-devel] [PATCH 00/10] locks/nfsd: internal lease API overhaul Christoph Hellwig
2014-08-25 1:43 ` Jeff Layton
2014-08-26 13:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140824154839.GB15908@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).