From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Date: Tue, 26 Aug 2014 06:59:20 -0700
Subject: [Cluster-devel] [PATCH 00/10] locks/nfsd: internal lease API
	overhaul
In-Reply-To: <20140824214301.61019123@synchrony.poochiereds.net>
References: <1408804878-1331-1-git-send-email-jlayton@primarydata.com>
	<20140824161046.GI15908@infradead.org>
	<20140824214301.61019123@synchrony.poochiereds.net>
Message-ID: <20140826135920.GB18599@infradead.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Sun, Aug 24, 2014 at 09:43:01PM -0400, Jeff Layton wrote:
> >  - add a return value to lm_break so that the lock manager can tell the
> >    core code "you can delete this lease right now".  That gets rid of
> >    the games with the timeout which require all kinds of race avoidance
> >    code in the users.
> > 
> 
> I'm not sure I understand what you're suggesting here. Isn't it just as
> simple to have lm_break call lease_modify to just remove the lease?

Unfortunately it's not.  lm_break gets a pointer to the file_lock,
and lease_modify needs a pointer to the list position of the file_lock.