From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Date: Mon, 19 Jan 2015 01:38:10 -0800
Subject: [Cluster-devel] [PATCH 12/17] xfs: Convert to using ->get_state
	callback
In-Reply-To: <1421412471-4747-13-git-send-email-jack@suse.cz>
References: <1421412471-4747-1-git-send-email-jack@suse.cz>
	<1421412471-4747-13-git-send-email-jack@suse.cz>
Message-ID: <20150119093810.GA16484@infradead.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

> +static void xfs_qm_fill_state(struct qc_type_state *tstate,

Normal xfs style would be to keep the "static void " on a separate line,
as well as the arguments, e.g.

static void
xfs_qm_fill_state(
	struct qc_type_state	*tstate,

>
> +			      struct xfs_mount *mp,
> +			      struct xfs_inode *ip,
> +			      xfs_ino_t ino)

No need to pass mp, as it can be derived as ip->i_mount.

Btw, I think this code should move into xfs_quotaops.c now
that it ties into the Linux quota interface, and xfs_qm_scall_getstate
should be folded into xfs_fs_get_quota_state.