cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units
Date: Tue, 20 Jan 2015 17:53:38 +0100	[thread overview]
Message-ID: <20150120165338.GC3648@quack.suse.cz> (raw)
In-Reply-To: <20150119090720.GG27474@infradead.org>

On Mon 19-01-15 01:07:20, Christoph Hellwig wrote:
> > diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> > index 18dc721ca19f..f718ba1f2ccb 100644
> > --- a/fs/xfs/libxfs/xfs_fs.h
> > +++ b/fs/xfs/libxfs/xfs_fs.h
> > @@ -559,18 +559,4 @@ typedef struct xfs_swapext
> >  /*	XFS_IOC_GETFSUUID ---------- deprecated 140	 */
> >  
> >  
> > -#ifndef HAVE_BBMACROS
> > -/*
> > - * Block I/O parameterization.	A basic block (BB) is the lowest size of
> > - * filesystem allocation, and must equal 512.  Length units given to bio
> > - * routines are in BB's.
> > - */
> > -#define BBSHIFT		9
> > -#define BBSIZE		(1<<BBSHIFT)
> > -#define BBMASK		(BBSIZE-1)
> > -#define BTOBB(bytes)	(((__u64)(bytes) + BBSIZE - 1) >> BBSHIFT)
> > -#define BTOBBT(bytes)	((__u64)(bytes) >> BBSHIFT)
> > -#define BBTOB(bbs)	((bbs) << BBSHIFT)
> > -#endif
> 
> Please don't move these defintions around and just opencode them in
> the quota code.
  I have moved the definitions because Dave asked me to use them in the XFS
parts of quota code (maybe he didn't realize that to be able to use them I
have to move the definitions somewhere where quota code can include them).
Dave? I personally don't care which variant will get used...

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
  Thanks.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR



  reply	other threads:[~2015-01-20 16:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 12:47 [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 01/17] quota: Split ->set_xstate callback into two Jan Kara
2015-01-19  9:00   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 02/17] quota: Wire up ->quota_{enable, disable} callbacks into Q_QUOTA{ON, OFF} Jan Kara
2015-01-19  9:01   ` Christoph Hellwig
2015-01-20 17:01     ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 03/17] quota: Add ->quota_{enable, disable} callbacks for VFS quotas Jan Kara
2015-01-19  9:02   ` Christoph Hellwig
2015-01-20 17:08     ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 04/17] ext4: Use generic helpers for quotaon and quotaoff Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 05/17] ocfs2: " Jan Kara
2015-01-19  9:03   ` Christoph Hellwig
2015-01-20 17:13     ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 06/17] quota: Remove quota_on_meta callback Jan Kara
2015-01-19  9:04   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 07/17] quota: Switch ->get_dqblk() and ->set_dqblk() to use bytes as space units Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-20 16:53     ` Jan Kara [this message]
2015-01-16 12:47 ` [Cluster-devel] [PATCH 08/17] quota: Store maximum space limit in bytes Jan Kara
2015-01-19  9:07   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 09/17] quota: Make Q_XQUOTASYNC support VFS quota syncing Jan Kara
2015-01-19  9:09   ` Christoph Hellwig
2015-01-20 17:16     ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 10/17] quota: Make VFS quotas use new interface for getting quota info Jan Kara
2015-01-19  9:10   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 11/17] quota: Wire up Q_GETXSTATE and Q_GETXSTATV calls to work with ->get_state Jan Kara
2015-01-19  9:11   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 12/17] xfs: Convert to using ->get_state callback Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-20 17:33     ` Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 13/17] gfs2: " Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 14/17] quota: Remove ->get_xstate and ->get_xstatev callbacks Jan Kara
2015-01-19  9:38   ` Christoph Hellwig
2015-01-16 12:47 ` [Cluster-devel] [PATCH 15/17] quota: Make ->set_info use structure with neccesary info to VFS and XFS Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 16/17] xfs: Add support for Q_SETINFO Jan Kara
2015-01-16 12:47 ` [Cluster-devel] [PATCH 17/17] quota: Hook up Q_XSETQLIM for id 0 to ->set_info Jan Kara
2015-01-21 21:38 ` [Cluster-devel] [PATCH 0/17 v3] quota: Unify VFS and XFS quota interfaces Dave Chinner
2015-01-21 22:23   ` Jan Kara
2015-01-21 23:10     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120165338.GC3648@quack.suse.cz \
    --to=jack@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).