From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Date: Wed, 18 Feb 2015 08:51:54 -0800
Subject: [Cluster-devel] [PATCH 3/8] xfs: Convert to using ->get_state
 callback
In-Reply-To: <1424267274-11836-4-git-send-email-jack@suse.cz>
References: <1424267274-11836-1-git-send-email-jack@suse.cz>
	<1424267274-11836-4-git-send-email-jack@suse.cz>
Message-ID: <20150218165154.GA29465@infradead.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

> +static void
> +xfs_qm_fill_state(
> +	struct qc_type_state *tstate,
> +	struct xfs_mount *mp,
> +	struct xfs_inode *ip,
> +	xfs_ino_t ino)

> +/*
> + * Return quota status information, such as enforcements, quota file inode
> + * numbers etc.
> + */
> +static int
> +xfs_fs_get_quota_state(
> +	struct super_block *sb,
> +	struct qc_state *state)

We usually tab-align the arguments in XFS prototypes.


Otherwise this patch looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>