From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 2/2][v2] blk-plug: don't flush nested plug lists
Date: Wed, 8 Apr 2015 18:13:55 +0200 [thread overview]
Message-ID: <20150408161355.GA16052@lst.de> (raw)
In-Reply-To: <x49wq1nrcoe.fsf_-_@segfault.boston.devel.redhat.com>
This looks good, but without the blk_finish_plug argument we're bound
to grow programming mistakes where people forget it. Any chance we
could have annotations similar to say rcu_read_lock/rcu_read_unlock
or the spinlocks so that sparse warns about it?
next prev parent reply other threads:[~2015-04-08 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1428347694-17704-1-git-send-email-jmoyer@redhat.com>
[not found] ` <1428347694-17704-2-git-send-email-jmoyer@redhat.com>
2015-04-07 18:55 ` [Cluster-devel] [PATCH 2/2][v2] blk-plug: don't flush nested plug lists Jeff Moyer
2015-04-08 16:13 ` Christoph Hellwig [this message]
2015-04-08 23:02 ` Dave Chinner
2015-04-09 0:54 ` Dave Chinner
2015-04-10 21:50 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408161355.GA16052@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).