From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 25 Sep 2015 10:41:06 -0700 Subject: [Cluster-devel] [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute In-Reply-To: <20150925142857.GA4449@mtj.duckdns.org> References: <1443189000-13398-1-git-send-email-hch@lst.de> <1443189000-13398-2-git-send-email-hch@lst.de> <20150925142857.GA4449@mtj.duckdns.org> Message-ID: <20150925174106.GA1402@kroah.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 25, 2015 at 10:28:57AM -0400, Tejun Heo wrote: > Hello, Christoph. > > On Fri, Sep 25, 2015 at 06:49:38AM -0700, Christoph Hellwig wrote: > > Add methods to struct configfs_attribute to directly show and store > > attributes without adding boilerplate code to every user. In addition > > to the methods this also adds 3 helper macros to define read/write, > > read-only and write-only attributes with a single line of code. > > This looks great to me. It doesn't look like the whole attribute > thing played out as hoped. It'd be great if we can move away from it. > > Thanks a lot for the work! Looks good to me as well, no objection from my side for the USB or core configfs stuff: Acked-by: Greg Kroah-Hartman