From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Date: Sun, 27 Sep 2015 10:50:53 -0500 Subject: [Cluster-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods In-Reply-To: <1443189000-13398-3-git-send-email-hch@lst.de> References: <1443189000-13398-1-git-send-email-hch@lst.de> <1443189000-13398-3-git-send-email-hch@lst.de> Message-ID: <20150927155053.GD16364@saruman.tx.rr.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Sep 25, 2015 at 06:49:39AM -0700, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/usb/gadget/configfs.c | 295 ++++++++++++++---------------------- > include/linux/usb/gadget_configfs.h | 19 +-- > 2 files changed, 118 insertions(+), 196 deletions(-) > > diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c > index 294eb74..163d305 100644 > --- a/drivers/usb/gadget/configfs.c > +++ b/drivers/usb/gadget/configfs.c > @@ -64,6 +64,11 @@ struct gadget_info { > char qw_sign[OS_STRING_QW_SIGN_LEN]; > }; > > +static inline struct gadget_info *to_gadget_info(struct config_item *item) > +{ > + return container_of(to_config_group(item), struct gadget_info, group); > +} this (and the other helper below) could be macros just fine. Are you 100% compiler will *always* inline these helpers. The likelyhood of not inlining is minimal, sure, but what do we get for writing these as functions instead of macros ? also, lacking commit log -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: