From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods
Date: Mon, 28 Sep 2015 15:35:14 +0200 [thread overview]
Message-ID: <20150928133514.GB30453@lst.de> (raw)
In-Reply-To: <20150927155053.GD16364@saruman.tx.rr.com>
On Sun, Sep 27, 2015 at 10:50:53AM -0500, Felipe Balbi wrote:
> this (and the other helper below) could be macros just fine.
They could, but they shouldn't. Inlines are always preferable over
function-like macros.
> Are you 100% compiler
> will *always* inline these helpers.
With gcc you can't ever be sure - but if it doesn't inline a trivial
pointer arithmetic we'll see breakage in various other places, including
the file system fast path which uses this pattern all over.
next prev parent reply other threads:[~2015-09-28 13:35 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 13:49 [Cluster-devel] simplify configfs attributes Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 01/23] configfs: add show and store methods to struct configfs_attribute Christoph Hellwig
2015-09-25 14:28 ` Tejun Heo
2015-09-25 17:41 ` Greg KH
2015-09-26 23:38 ` Nicholas A. Bellinger
2015-09-25 13:49 ` [Cluster-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods Christoph Hellwig
2015-09-27 15:47 ` Felipe Balbi
2015-09-28 13:33 ` Christoph Hellwig
2015-10-01 17:23 ` Felipe Balbi
2015-09-27 15:50 ` Felipe Balbi
2015-09-28 13:35 ` Christoph Hellwig [this message]
2015-09-30 16:19 ` Felipe Balbi
2015-09-30 16:20 ` Tejun Heo
2015-09-30 16:32 ` Felipe Balbi
2015-09-30 16:35 ` Tejun Heo
2015-09-30 16:43 ` Felipe Balbi
2015-09-30 16:59 ` Tejun Heo
2015-09-28 10:54 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 03/23] usb-gadget/uvc: " Christoph Hellwig
2015-09-28 11:35 ` Andrzej Pietrasiewicz
2015-09-28 13:39 ` Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 04/23] usb-gadget/f_hid: " Christoph Hellwig
2015-09-28 11:37 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 05/23] usb-gadget/f_acm: " Christoph Hellwig
2015-09-28 11:39 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 06/23] usb-gadget/ether: " Christoph Hellwig
2015-09-28 11:40 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 07/23] usb-gadget/f_loopback: " Christoph Hellwig
2015-09-28 11:46 ` Andrzej Pietrasiewicz
2015-09-28 13:41 ` Christoph Hellwig
2015-09-28 13:52 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 08/23] usb-gadget/f_midi: " Christoph Hellwig
2015-09-28 11:47 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 09/23] usb-gadget/f_printer: " Christoph Hellwig
2015-09-28 11:50 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 10/23] usb-gadget/f_sourcesink: " Christoph Hellwig
2015-09-28 11:51 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 11/23] usb-gadget/f_mass_storage: " Christoph Hellwig
2015-09-28 11:53 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 12/23] usb-gadget/f_ac1: " Christoph Hellwig
2015-09-28 11:56 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 13/23] usb-gadget/f_uac2: " Christoph Hellwig
2015-09-28 11:56 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 14/23] usb-gadget/f_obex: " Christoph Hellwig
2015-09-28 11:57 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 15/23] usb-gadget/f_phonet: " Christoph Hellwig
2015-09-28 11:59 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 16/23] usb-gadget/f_serial: " Christoph Hellwig
2015-09-28 11:59 ` Andrzej Pietrasiewicz
2015-09-25 13:49 ` [Cluster-devel] [PATCH 17/23] dlm: " Christoph Hellwig
2015-09-28 14:49 ` David Teigland
2015-09-25 13:49 ` [Cluster-devel] [PATCH 18/23] spear13xx_pcie_gadget: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 19/23] target: " Christoph Hellwig
2015-09-26 23:35 ` Nicholas A. Bellinger
2015-09-25 13:49 ` [Cluster-devel] [PATCH 20/23] netconsole: " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 21/23] ocfs2/cluster: move locking into attribute " Christoph Hellwig
2015-09-25 13:49 ` [Cluster-devel] [PATCH 22/23] ocfs2/cluster: use per-attribute show and " Christoph Hellwig
2015-09-25 13:50 ` [Cluster-devel] [PATCH 23/23] configfs: remove old API Christoph Hellwig
2015-09-28 12:06 ` Andrzej Pietrasiewicz
2015-09-28 13:42 ` Christoph Hellwig
2015-09-25 13:57 ` [Cluster-devel] simplify configfs attributes Christoph Hellwig
2015-09-26 23:49 ` Nicholas A. Bellinger
2015-09-27 6:30 ` Christoph Hellwig
2015-09-28 12:12 ` Andrzej Pietrasiewicz
-- strict thread matches above, loose matches on Subject: below --
2015-10-03 13:32 [Cluster-devel] simplify configfs attributes V2 Christoph Hellwig
2015-10-03 13:32 ` [Cluster-devel] [PATCH 02/23] usb-gadget: use per-attribute show and store methods Christoph Hellwig
2015-10-09 21:19 ` Felipe Balbi
2015-10-11 13:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150928133514.GB30453@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).