From: Dave Chinner <david@fromorbit.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] fs: return EPERM on immutable inode
Date: Wed, 6 Apr 2016 06:44:30 +1000 [thread overview]
Message-ID: <20160405204430.GG11238@dastard> (raw)
In-Reply-To: <1459862890-22957-1-git-send-email-guaneryu@gmail.com>
On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote:
> In most cases, EPERM is returned on immutable inode, and there're only
> a few places returning EACCES. And EPERM looks more reasonable to me.
>
> So converting all EACCES to EPERM on immutable inode.
>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
> ---
>
> I noticed this when running LTP on overlayfs, setxattr03 failed due to
> unexpected EACCES on immutable inode.
This should be in the commit message itself, rather than "EPERM
looks more reasonable".
Other than that, change seems fine to me.
Acked-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david at fromorbit.com
next prev parent reply other threads:[~2016-04-05 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 13:28 [Cluster-devel] [PATCH] fs: return EPERM on immutable inode Eryu Guan
2016-04-05 20:44 ` Dave Chinner [this message]
2016-04-06 3:44 ` [Cluster-devel] [PATCH v2] " Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405204430.GG11238@dastard \
--to=david@fromorbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).