From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Date: Wed, 6 Apr 2016 06:44:30 +1000 Subject: [Cluster-devel] [PATCH] fs: return EPERM on immutable inode In-Reply-To: <1459862890-22957-1-git-send-email-guaneryu@gmail.com> References: <1459862890-22957-1-git-send-email-guaneryu@gmail.com> Message-ID: <20160405204430.GG11238@dastard> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Apr 05, 2016 at 09:28:10PM +0800, Eryu Guan wrote: > In most cases, EPERM is returned on immutable inode, and there're only > a few places returning EACCES. And EPERM looks more reasonable to me. > > So converting all EACCES to EPERM on immutable inode. > > Signed-off-by: Eryu Guan > --- > > I noticed this when running LTP on overlayfs, setxattr03 failed due to > unexpected EACCES on immutable inode. This should be in the commit message itself, rather than "EPERM looks more reasonable". Other than that, change seems fine to me. Acked-by: Dave Chinner -- Dave Chinner david at fromorbit.com