From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 18 Aug 2016 11:21:54 -0700 Subject: [Cluster-devel] [GFS2 PATCH][v2] GFS2: Add function gfs2_get_iomap In-Reply-To: <225698410.3303717.1471031879076.JavaMail.zimbra@redhat.com> References: <1935983818.2525484.1470927576083.JavaMail.zimbra@redhat.com> <57AC990C.3040909@redhat.com> <225698410.3303717.1471031879076.JavaMail.zimbra@redhat.com> Message-ID: <20160818182154.GA23798@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Aug 12, 2016 at 03:57:59PM -0400, Bob Peterson wrote: > | Is there a better way to pass the gh from the begin function to the end > | function? I'm sure that will work, but it is the kind of thing that > | might trip up the unwary in the future, > > Yeah, I would have passed the gh another way, but Christoph didn't > leave a good way in the iomap interface or other bits to do it. > At least not that I can see. It might be worth changing the interface to > add that flexibility for other file systems that might want to do this > as well. It would be easy enough to add a (void *)private pointer or > something that can be passed around. Christoph and Steve: Would you > prefer I plumb something before I do the GFS2 bits? The interface is not set in stone. If you have a good suggestion to improve it for your use case, send a patch.