From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/4] GFS2: Switch fiemap implementation to use iomap
Date: Fri, 21 Oct 2016 05:08:27 -0700 [thread overview]
Message-ID: <20161021120827.GB26742@infradead.org> (raw)
In-Reply-To: <1476980065-10663-5-git-send-email-rpeterso@redhat.com>
> + iomap->private = (void *)gh;
No need to cast here. And while we're at it: please split the
addition of ->private into a separate patch.
> + struct gfs2_holder *gh = (struct gfs2_holder *)iomap->private;
Same here.
prev parent reply other threads:[~2016-10-21 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 16:14 [Cluster-devel] [PATCH 0/4] Implement iomap for fiemap in GFS2 Bob Peterson
2016-10-20 16:14 ` [Cluster-devel] [PATCH 1/4] GFS2: Remove bh_map requirements from gfs2_bmap_alloc Bob Peterson
2016-10-20 16:14 ` [Cluster-devel] [PATCH 2/4] GFS2: Make height info part of metapath Bob Peterson
2016-10-20 16:14 ` [Cluster-devel] [PATCH 3/4] GFS2: Implement iomap for block_map Bob Peterson
2016-10-20 17:05 ` Steven Whitehouse
2016-10-20 16:14 ` [Cluster-devel] [PATCH 4/4] GFS2: Switch fiemap implementation to use iomap Bob Peterson
2016-10-21 12:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021120827.GB26742@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).