From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 21 Oct 2016 05:08:27 -0700 Subject: [Cluster-devel] [PATCH 4/4] GFS2: Switch fiemap implementation to use iomap In-Reply-To: <1476980065-10663-5-git-send-email-rpeterso@redhat.com> References: <1476980065-10663-1-git-send-email-rpeterso@redhat.com> <1476980065-10663-5-git-send-email-rpeterso@redhat.com> Message-ID: <20161021120827.GB26742@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > + iomap->private = (void *)gh; No need to cast here. And while we're at it: please split the addition of ->private into a separate patch. > + struct gfs2_holder *gh = (struct gfs2_holder *)iomap->private; Same here.