cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/6] lockdep: allow to disable reclaim lockup detection
Date: Mon, 6 Feb 2017 06:26:41 -0800	[thread overview]
Message-ID: <20170206142641.GG2267@bombadil.infradead.org> (raw)
In-Reply-To: <20170206140718.16222-2-mhocko@kernel.org>

On Mon, Feb 06, 2017 at 03:07:13PM +0100, Michal Hocko wrote:
> While we are at it also make sure that the radix tree doesn't
> accidentaly override tags stored in the upper part of the gfp_mask.

> diff --git a/lib/radix-tree.c b/lib/radix-tree.c
> index 9dc093d5ef39..7550be09f9d6 100644
> --- a/lib/radix-tree.c
> +++ b/lib/radix-tree.c
> @@ -2274,6 +2274,8 @@ static int radix_tree_cpu_dead(unsigned int cpu)
>  void __init radix_tree_init(void)
>  {
>  	int ret;
> +
> +	BUILD_BUG_ON(RADIX_TREE_MAX_TAGS + __GFP_BITS_SHIFT > 32);
>  	radix_tree_node_cachep = kmem_cache_create("radix_tree_node",
>  			sizeof(struct radix_tree_node), 0,
>  			SLAB_PANIC | SLAB_RECLAIM_ACCOUNT,

That's going to have a conceptual conflict with some patches I have
in flight.  I'll take this part through my radix tree patch collection.



  reply	other threads:[~2017-02-06 14:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 14:07 [Cluster-devel] [PATCH 0/6 v4] scope GFP_NOFS api Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 1/6] lockdep: allow to disable reclaim lockup detection Michal Hocko
2017-02-06 14:26   ` Matthew Wilcox [this message]
2017-02-06 14:34     ` Michal Hocko
2017-02-06 15:24       ` Matthew Wilcox
2017-02-06 15:30         ` Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 2/6] xfs: abstract PF_FSTRANS to PF_MEMALLOC_NOFS Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 3/6] mm: introduce memalloc_nofs_{save, restore} API Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 4/6] xfs: use memalloc_nofs_{save, restore} instead of memalloc_noio* Michal Hocko
2017-02-06 15:39   ` Matthew Wilcox
2017-02-06 17:44     ` Michal Hocko
2017-02-06 18:32       ` Darrick J. Wong
2017-02-06 18:47         ` Michal Hocko
2017-02-06 19:51           ` Darrick J. Wong
2017-02-06 21:18             ` Michal Hocko
2017-02-06 22:51           ` Dave Chinner
2017-02-07  7:17             ` Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 5/6] jbd2: mark the transaction context with the scope GFP_NOFS context Michal Hocko
2017-02-06 14:07 ` [Cluster-devel] [PATCH 6/6] jbd2: make the whole kjournald2 kthread NOFS safe Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170206142641.GG2267@bombadil.infradead.org \
    --to=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).