cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 08/20] mm: ensure that we set mapping error if writeout() fails
Date: Mon, 24 Apr 2017 09:22:47 -0400	[thread overview]
Message-ID: <20170424132259.8680-9-jlayton@redhat.com> (raw)
In-Reply-To: <20170424132259.8680-1-jlayton@redhat.com>

If writepage fails during a page migration, then we need to ensure that
fsync will see it by flagging the mapping.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 mm/migrate.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index 738f1d5f8350..3a59830bdae2 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -792,7 +792,11 @@ static int writeout(struct address_space *mapping, struct page *page)
 		/* unlocked. Relock */
 		lock_page(page);
 
-	return (rc < 0) ? -EIO : -EAGAIN;
+	if (rc < 0) {
+		mapping_set_error(mapping, rc);
+		return -EIO;
+	}
+	return -EAGAIN;
 }
 
 /*
-- 
2.9.3



  parent reply	other threads:[~2017-04-24 13:22 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 13:22 [Cluster-devel] [PATCH v3 00/20] fs: introduce new writeback error reporting and convert existing API as a wrapper around it Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 01/20] mm: drop "wait" parameter from write_one_page Jeff Layton
2017-04-24 15:22   ` Christoph Hellwig
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 02/20] mm: fix mapping_set_error call in me_pagecache_dirty Jeff Layton
2017-04-24 15:22   ` Christoph Hellwig
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 03/20] buffer: use mapping_set_error instead of setting the flag Jeff Layton
2017-04-24 15:22   ` Christoph Hellwig
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 04/20] fs: check for writeback errors after syncing out buffers in generic_file_fsync Jeff Layton
2017-04-24 15:23   ` Christoph Hellwig
2017-04-24 15:46   ` Jan Kara
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 05/20] orangefs: don't call filemap_write_and_wait from fsync Jeff Layton
2017-04-24 15:23   ` Christoph Hellwig
2017-04-24 18:18     ` Mike Marshall
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 06/20] dax: set errors in mapping when writeback fails Jeff Layton
2017-04-24 15:24   ` Christoph Hellwig
2017-04-24 15:54   ` Jan Kara
2017-04-24 19:16   ` Ross Zwisler
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 07/20] nilfs2: set the mapping error when calling SetPageError on writeback Jeff Layton
2017-04-24 15:24   ` Christoph Hellwig
2017-04-24 13:22 ` Jeff Layton [this message]
2017-04-24 15:24   ` [Cluster-devel] [PATCH v3 08/20] mm: ensure that we set mapping error if writeout() fails Christoph Hellwig
2017-04-24 15:56   ` Jan Kara
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 09/20] 9p: set mapping error when writeback fails in launder_page Jeff Layton
2017-04-24 15:24   ` Christoph Hellwig
2017-04-24 15:57   ` Jan Kara
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 10/20] fuse: set mapping error in writepage_locked when it fails Jeff Layton
2017-04-24 15:25   ` Christoph Hellwig
2017-04-24 16:04   ` Jan Kara
2017-04-24 17:14     ` Jeff Layton
2017-04-25  8:17       ` Jan Kara
2017-04-25 10:35         ` Jeff Layton
2017-04-25 11:19           ` Jan Kara
2017-04-25 16:43             ` Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 11/20] cifs: set mapping error when page writeback fails in writepage or launder_pages Jeff Layton
2017-04-24 15:27   ` Christoph Hellwig
2017-04-24 17:16     ` Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 12/20] lib: add errseq_t type and infrastructure for handling it Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 13/20] fs: new infrastructure for writeback error handling and reporting Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 14/20] fs: retrofit old error reporting API onto new infrastructure Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 15/20] mm: remove AS_EIO and AS_ENOSPC flags Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 16/20] mm: don't TestClearPageError in __filemap_fdatawait_range Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 17/20] cifs: cleanup writeback handling errors and comments Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 18/20] mm: clean up error handling in write_one_page Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 19/20] jbd2: don't reset error in journal_finish_inode_data_buffers Jeff Layton
2017-04-24 13:22 ` [Cluster-devel] [PATCH v3 20/20] gfs2: clean up some filemap_* calls Jeff Layton
2017-04-24 14:12   ` Bob Peterson
2017-04-24 16:59     ` Jeff Layton
2017-04-24 17:41       ` Bob Peterson
2017-04-24 17:52         ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424132259.8680-9-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).