From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Date: Mon, 24 Apr 2017 08:23:35 -0700
Subject: [Cluster-devel] [PATCH v3 04/20] fs: check for writeback errors
 after syncing out buffers in generic_file_fsync
In-Reply-To: <20170424132259.8680-5-jlayton@redhat.com>
References: <20170424132259.8680-1-jlayton@redhat.com>
	<20170424132259.8680-5-jlayton@redhat.com>
Message-ID: <20170424152335.GD9112@infradead.org>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

>  out:
>  	inode_unlock(inode);
> -	return ret;
> +	err = filemap_check_errors(inode->i_mapping);
> +	return ret ? : err;

Can you spell out the whole unary operation instead of this weird GCC
extension?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>