From: Fabian Frederick <fabf@skynet.be>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2 linux-next] gfs2: check rename2 flags at once
Date: Wed, 3 May 2017 20:27:46 +0200 [thread overview]
Message-ID: <20170503182746.20076-1-fabf@skynet.be> (raw)
There's no need to update flags in gfs2_rename2()
This will ease whiteout addition.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/gfs2/inode.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 9f605ea..9698796 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1706,9 +1706,7 @@ static int gfs2_rename2(struct inode *odir, struct dentry *odentry,
struct inode *ndir, struct dentry *ndentry,
unsigned int flags)
{
- flags &= ~RENAME_NOREPLACE;
-
- if (flags & ~RENAME_EXCHANGE)
+ if (flags & ~(RENAME_NOREPLACE | RENAME_EXCHANGE))
return -EINVAL;
if (flags & RENAME_EXCHANGE)
--
2.9.3
next reply other threads:[~2017-05-03 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 18:27 Fabian Frederick [this message]
2017-05-04 13:28 ` [Cluster-devel] [PATCH 1/2 linux-next] gfs2: check rename2 flags at once Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503182746.20076-1-fabf@skynet.be \
--to=fabf@skynet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).