From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Wed, 10 May 2017 05:48:36 -0700 Subject: [Cluster-devel] [PATCH v4 06/27] fs: check for writeback errors after syncing out buffers in generic_file_fsync In-Reply-To: <20170509154930.29524-7-jlayton@redhat.com> References: <20170509154930.29524-1-jlayton@redhat.com> <20170509154930.29524-7-jlayton@redhat.com> Message-ID: <20170510124836.GA1590@bombadil.infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, May 09, 2017 at 11:49:09AM -0400, Jeff Layton wrote: > ext2 currently does a test+clear of the AS_EIO flag, which is > is problematic for some coming changes. > > What we really need to do instead is call filemap_check_errors > in __generic_file_fsync after syncing out the buffers. That > will be sufficient for this case, and help other callers detect > these errors properly as well. > > With that, we don't need to twiddle it in ext2. > > Suggested-by: Jan Kara > Signed-off-by: Jeff Layton > Reviewed-by: Christoph Hellwig > Reviewed-by: Jan Kara Reviewed-by: Matthew Wilcox