cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] generic/441: whitelist gfs2 for full test
Date: Mon, 31 Jul 2017 16:49:07 +0800	[thread overview]
Message-ID: <20170731084907.GH9167@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170728104827.7260-1-jlayton@kernel.org>

On Fri, Jul 28, 2017 at 06:48:27AM -0400, Jeff Layton wrote:
> From: Jeff Layton <jlayton@redhat.com>
> 
> gfs2 passes the full-scale generic/441 test with the patch that
> converts it to use errseq_t reporting for fsync.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
>  tests/generic/441 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/441 b/tests/generic/441
> index 075d87723ca1..b98f709cb6eb 100755
> --- a/tests/generic/441
> +++ b/tests/generic/441
> @@ -55,7 +55,7 @@ case $FSTYP in
>  	btrfs)
>  		_notrun "btrfs has a specialized test for this"
>  		;;
> -	ext3|ext4|xfs)
> +	ext3|ext4|gfs2|xfs)

gfs2 has no external log device support yet in _scratch_mkfs, so if test
still passes with patched gfs2 in this case, I think we can test gfs2 in
full-scale mode unconditionally? e.g.

	ext3|ext4|xfs)
 		# Do the more thorough test if we have a logdev
 		_has_logdev && sflag=''
 		;;
	gfs2)
		# <comments here>
		sflag=''
		;;
	*)
		;;

Thanks,
Eryu



  reply	other threads:[~2017-07-31  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 10:48 [Cluster-devel] [PATCH] generic/441: whitelist gfs2 for full test Jeff Layton
2017-07-31  8:49 ` Eryu Guan [this message]
2017-09-13 13:04 ` [Cluster-devel] [xfstests PATCH][RESEND] " Jeff Layton
2017-09-14  6:16   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731084907.GH9167@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).