cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v3 0/4] GFS2 shrinker deadlock
Date: Tue,  1 Aug 2017 02:00:18 +0200	[thread overview]
Message-ID: <20170801000022.13295-1-agruenba@redhat.com> (raw)

With the recent gl_object fixes and an additional reference counting bug
fixed in this patch queue, these four remaining shrinker deadlock
avoidance patches now seem ready for mainline.

As explained in the previous posting of this patch queue, when inodes
are evicted, GFS2 currently calls into DLM.  Inode eviction can be
triggered by memory pressure, in the context of a random user-space
process.  If DLM happens to block in the process in question (for
example, it that process is a fence agent), GFS2 and DLM will deadlock.

This patch queue stops GFS2 from calling into DLM on the inode evict
path under memory pressure.  It does so by first decoupling destroying
inodes and putting their associated glocks, which is what ends up
calling into DLM.  Second, when under memory pressure, it moves putting
glocks into work queue context where it cannot block DLM.  Third, when
gfs2_drop_inode determines that an inode's link count has hit zero under
memory pressure, it puts that inode on the delete workqueue (and keeps
the inode in the icache) instead of causing gfs2_evict_inode to delete
the inode immediately.  The delete workqueue will not be processed under
memory pressure, so deleting inodes from there is safe.

Thanks,
Andreas

Andreas Gruenbacher (4):
  gfs2: gfs2_glock_get: Wait on freeing glocks
  gfs2: Get rid of gfs2_set_nlink
  gfs2: gfs2_evict_inode: Put glocks asynchronously
  gfs2: Defer deleting inodes under memory pressure

 fs/gfs2/glock.c | 135 +++++++++++++++++++++++++++++++++++++++++++++++---------
 fs/gfs2/glock.h |   2 +
 fs/gfs2/glops.c |  28 +-----------
 fs/gfs2/super.c |  43 +++++++++++++++++-
 4 files changed, 157 insertions(+), 51 deletions(-)

-- 
2.13.3



             reply	other threads:[~2017-08-01  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01  0:00 Andreas Gruenbacher [this message]
2017-08-01  0:00 ` [Cluster-devel] [PATCH v3 1/4] gfs2: gfs2_glock_get: Wait on freeing glocks Andreas Gruenbacher
2017-08-03 12:04   ` Andrew Price
2017-08-01  0:00 ` [Cluster-devel] [PATCH v3 2/4] gfs2: Get rid of gfs2_set_nlink Andreas Gruenbacher
2017-08-01  0:00 ` [Cluster-devel] [PATCH v3 3/4] gfs2: gfs2_evict_inode: Put glocks asynchronously Andreas Gruenbacher
2017-08-01  0:00 ` [Cluster-devel] [PATCH v3 4/4] gfs2: Defer deleting inodes under memory pressure Andreas Gruenbacher
2017-08-01 17:00 ` [Cluster-devel] [PATCH v3 0/4] GFS2 shrinker deadlock Bob Peterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801000022.13295-1-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).