From: Andrew Price <anprice@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 16/20] libgfs2: Remove gfs2_log_header_out_bh
Date: Mon, 5 Mar 2018 18:25:45 +0000 [thread overview]
Message-ID: <20180305182549.17817-17-anprice@redhat.com> (raw)
In-Reply-To: <20180305182549.17817-1-anprice@redhat.com>
Signed-off-by: Andrew Price <anprice@redhat.com>
---
gfs2/fsck/fs_recovery.c | 3 ++-
gfs2/libgfs2/libgfs2.h | 1 -
gfs2/libgfs2/ondisk.c | 6 ------
gfs2/libgfs2/structures.c | 2 +-
4 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/gfs2/fsck/fs_recovery.c b/gfs2/fsck/fs_recovery.c
index 740334da..677abd75 100644
--- a/gfs2/fsck/fs_recovery.c
+++ b/gfs2/fsck/fs_recovery.c
@@ -444,7 +444,8 @@ static int check_journal_seq_no(struct gfs2_inode *ip, int fix)
log_warn( _("Renumbering it as 0x%llx\n"), lh.lh_sequence);
block_map(ip, blk, &new, &dblock, NULL, FALSE);
bh = bread(ip->i_sbd, dblock);
- gfs2_log_header_out_bh(&lh, bh);
+ gfs2_log_header_out(&lh, bh->b_data);
+ bmodified(bh);
brelse(bh);
}
if (seq_errors && fix) {
diff --git a/gfs2/libgfs2/libgfs2.h b/gfs2/libgfs2/libgfs2.h
index 82900fb5..f83caaad 100644
--- a/gfs2/libgfs2/libgfs2.h
+++ b/gfs2/libgfs2/libgfs2.h
@@ -742,7 +742,6 @@ extern void gfs2_log_header_v1_in(struct gfs2_log_header *lh, char *buf);
extern void gfs2_log_header_in(struct gfs2_log_header *lh, char *buf);
extern void gfs2_log_header_v1_out(struct gfs2_log_header *lh, char *buf);
extern void gfs2_log_header_out(struct gfs2_log_header *lh, char *buf);
-extern void gfs2_log_header_out_bh(struct gfs2_log_header *lh, struct gfs2_buffer_head *bh);
extern void gfs2_log_descriptor_in(struct gfs2_log_descriptor *ld,
struct gfs2_buffer_head *bh);
extern void gfs2_log_descriptor_out(struct gfs2_log_descriptor *ld,
diff --git a/gfs2/libgfs2/ondisk.c b/gfs2/libgfs2/ondisk.c
index fb8815d7..d030cb16 100644
--- a/gfs2/libgfs2/ondisk.c
+++ b/gfs2/libgfs2/ondisk.c
@@ -597,12 +597,6 @@ void gfs2_log_header_out(struct gfs2_log_header *lh, char *buf)
#endif
}
-void gfs2_log_header_out_bh(struct gfs2_log_header *lh, struct gfs2_buffer_head *bh)
-{
- gfs2_log_header_out(lh, bh->iov.iov_base);
- bmodified(bh);
-}
-
void gfs2_log_header_v1_print(const struct gfs2_log_header *lh)
{
gfs2_meta_header_print(&lh->lh_header);
diff --git a/gfs2/libgfs2/structures.c b/gfs2/libgfs2/structures.c
index 51e7d077..310ba3c1 100644
--- a/gfs2/libgfs2/structures.c
+++ b/gfs2/libgfs2/structures.c
@@ -232,7 +232,7 @@ int write_journal(struct gfs2_inode *jnl, unsigned bsize, unsigned int blocks)
memset(bh->b_data, 0, bsize);
lh.lh_sequence = seq;
lh.lh_blkno = x;
- gfs2_log_header_out_bh(&lh, bh);
+ gfs2_log_header_out(&lh, bh->b_data);
hash = lgfs2_log_header_hash(bh->b_data);
((struct gfs2_log_header *)bh->b_data)->lh_hash = cpu_to_be32(hash);
#ifdef GFS2_HAS_LH_V2
--
2.14.3
next prev parent reply other threads:[~2018-03-05 18:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:25 [Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 01/20] libgfs2: Remove unused lock* fields from gfs2_sbd Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 02/20] libgfs2: Remove sb_addr " Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 03/20] libgfs2: Plug an alignment hole in gfs2_sbd Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 04/20] libgfs2: Plug an alignment hole in gfs2_buffer_head Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 05/20] libgfs2: Plug an alignment hole in gfs2_inode Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 06/20] libgfs2: Remove gfs2_meta_header_out_bh() Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 07/20] libgfs2: Don't pass an extlen to block_map where not required Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 08/20] libgfs2: Don't use a buffer_head in gfs2_meta_header_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 09/20] libgfs2: Don't use buffer_heads in gfs2_sb_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 10/20] libgfs2: Don't use buffer_heads in gfs2_rgrp_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 11/20] libgfs2: Remove gfs2_rgrp_out_bh Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 12/20] libgfs2: Don't use buffer_heads in gfs2_dinode_in Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 13/20] libgfs2: Remove gfs2_dinode_out_bh Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 14/20] libgfs2: Don't use buffer_heads in gfs2_leaf_{in, out} Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 15/20] libgfs2: Don't use buffer_heads in gfs2_log_header_in Andrew Price
2018-03-05 18:25 ` Andrew Price [this message]
2018-03-05 18:25 ` [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out} Andrew Price
2018-03-05 19:00 ` Bob Peterson
2018-03-05 19:15 ` Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 18/20] libgfs2: Don't use buffer_heads in gfs2_quota_change_{in, out} Andrew Price
2018-03-05 19:02 ` Bob Peterson
2018-03-05 18:25 ` [Cluster-devel] [PATCH 19/20] libgfs2: Fix two unused variable warnings Andrew Price
2018-03-05 18:25 ` [Cluster-devel] [PATCH 20/20] mkfs.gfs2: Silence an integer overflow warning Andrew Price
2018-03-05 19:08 ` [Cluster-devel] [PATCH 00/20] gfs2-utils: Misc. tidy-ups Bob Peterson
2018-03-05 19:19 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305182549.17817-17-anprice@redhat.com \
--to=anprice@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).