From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Date: Sat, 2 Jun 2018 19:06:37 +0200
Subject: [Cluster-devel] [PATCH v6 5/9] iomap: Add write_end iomap
	operation
In-Reply-To: <20180602095717.31641-6-agruenba@redhat.com>
References: <20180602095717.31641-1-agruenba@redhat.com>
	<20180602095717.31641-6-agruenba@redhat.com>
Message-ID: <20180602170637.GD15847@lst.de>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Sat, Jun 02, 2018 at 11:57:13AM +0200, Andreas Gruenbacher wrote:
> Add a write_end operation to struct iomap_ops to provide a way of
> overriding the default behavior of iomap_write_end.  This will be used
> for implementing data journaling in gfs2: in the data journaling case,
> pages are written into the journal before being written back to their
> proper on-disk locations.

Please names this page_write_end and make it an optional callout
just for the additional functionality, that is keep the call to
iomap_write_end hardcoded in iomap.c, just call the new method before
it.

> +
> +struct iomap_write_args {
> +	const struct iomap_ops *ops;
> +	struct iov_iter *iter;
> +};

Also I wonder if we should just pass the iomap_ops diretly to the actor
callback.