cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Darrick J. Wong <darrick.wong@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 3/3] iomap: add inline data support to iomap_readpage_actor
Date: Tue, 3 Jul 2018 09:06:41 -0700	[thread overview]
Message-ID: <20180703160641.GX5711@magnolia> (raw)
In-Reply-To: <20180702145458.22330-4-hch@lst.de>

On Mon, Jul 02, 2018 at 08:54:58AM -0600, Christoph Hellwig wrote:
> From: Andreas Gruenbacher <agruenba@redhat.com>
> 
> Just copy the inline data into the page using the existing helper.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/iomap.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/iomap.c b/fs/iomap.c
> index 98a1fdd5c091..13cdcf33e6c0 100644
> --- a/fs/iomap.c
> +++ b/fs/iomap.c
> @@ -155,6 +155,12 @@ iomap_readpage_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
>  	bool is_contig = false;
>  	sector_t sector;
>  
> +	if (iomap->type == IOMAP_INLINE) {
> +		WARN_ON_ONCE(poff);
> +		iomap_read_inline_data(inode, page, iomap);
> +		return PAGE_SIZE;
> +	}
> +
>  	/* we don't support blocksize < PAGE_SIZE quite yet. */
>  	WARN_ON_ONCE(pos != page_offset(page));
>  	WARN_ON_ONCE(plen != PAGE_SIZE);
> -- 
> 2.18.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



      reply	other threads:[~2018-07-03 16:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 14:54 [Cluster-devel] more iomap inline enablement Christoph Hellwig
2018-07-02 14:54 ` [Cluster-devel] [PATCH 1/3] iomap: refactor iomap_dio_actor Christoph Hellwig
2018-07-03 16:07   ` Darrick J. Wong
2018-07-02 14:54 ` [Cluster-devel] [PATCH 2/3] iomap: support direct I/O to inline data Christoph Hellwig
2018-07-03 16:06   ` Darrick J. Wong
2018-07-02 14:54 ` [Cluster-devel] [PATCH 3/3] iomap: add inline data support to iomap_readpage_actor Christoph Hellwig
2018-07-03 16:06   ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180703160641.GX5711@magnolia \
    --to=darrick.wong@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).