From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Tue, 17 Jul 2018 16:02:58 +0200 Subject: [Cluster-devel] [PATCH 5/6] iomap: add a page_done callback In-Reply-To: <20180713025853.xugxx6zte3kvvqjy@merlin> References: <20180619164137.13720-1-hch@lst.de> <20180619164137.13720-6-hch@lst.de> <20180713025853.xugxx6zte3kvvqjy@merlin> Message-ID: <20180717140258.GA18365@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Jul 12, 2018 at 09:58:53PM -0500, Goldwyn Rodrigues wrote: > Would it be better if we keep this function as a part of iomap_ops? I > know gfs2 sets this conditionally, but we can always check the condition > in the function assigned to page_done(). It would keep all the functions > in one place. It works at a very different level than the other iomap ops. We had extensive discussions on previous versions, it should all be on the list.