From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH 4/4] gfs2: read journal in large chunks to locate the head
Date: Wed, 17 Oct 2018 02:43:08 -0700 [thread overview]
Message-ID: <20181017094308.GA18118@infradead.org> (raw)
In-Reply-To: <1539662878-13664-5-git-send-email-adas@redhat.com>
> +/**
> + * gfs2_end_log_read - end I/O callback for reads from the log
> + * @bio: The bio
> + *
> + * Simply unlock the pages in the bio. The main thread will wait on them and
> + * process them in order as necessary.
> + */
> +
> +static void gfs2_end_log_read(struct bio *bio)
> +{
> + struct gfs2_sbd *sdp = bio->bi_private;
> + struct page *page;
> + struct bio_vec *bvec;
> + int i;
> +
> + if (bio->bi_status)
> + fs_err(sdp, "Error %d reading from journal\n", bio->bi_status);
How is error handling forthis going to work?
> + bio_set_op_attrs(bio, REQ_OP_READ, 0);
Please assign to bi_opf directly instead of using bio_set_op_attrs.
next prev parent reply other threads:[~2018-10-17 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 4:07 [Cluster-devel] [GFS2 PATCH 0/4] jhead lookup using bios Abhi Das
2018-10-16 4:07 ` [Cluster-devel] [GFS2 PATCH 1/4] gfs2: add more timing info to journal recovery process Abhi Das
2018-10-16 9:05 ` Andreas Gruenbacher
2018-10-16 4:07 ` [Cluster-devel] [GFS2 PATCH 2/4] gfs2: changes to gfs2_log_XXX_bio Abhi Das
2018-10-16 4:07 ` [Cluster-devel] [GFS2 PATCH 3/4] gfs2: add a helper function to get_log_header that can be used elsewhere Abhi Das
2018-10-16 9:07 ` Andreas Gruenbacher
2018-10-16 4:07 ` [Cluster-devel] [GFS2 PATCH 4/4] gfs2: read journal in large chunks to locate the head Abhi Das
2018-10-17 9:43 ` Christoph Hellwig [this message]
2018-10-17 15:19 ` Abhijith Das
2018-10-17 9:32 ` [Cluster-devel] [GFS2 PATCH 0/4] jhead lookup using bios Steven Whitehouse
2018-11-12 14:29 ` Bob Peterson
-- strict thread matches above, loose matches on Subject: below --
2018-09-06 17:02 [Cluster-devel] [GFS2 PATCH 0/4] Speed up journal head lookup Abhi Das
2018-09-06 17:02 ` [Cluster-devel] [GFS2 PATCH 4/4] gfs2: read journal in large chunks to locate the head Abhi Das
2018-09-07 12:14 ` Andreas Gruenbacher
2018-09-07 12:51 ` Abhijith Das
2018-09-07 12:46 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017094308.GA18118@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).