cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH V10 14/19] block: enable multipage bvecs
Date: Thu, 15 Nov 2018 16:53:01 +0800	[thread overview]
Message-ID: <20181115085306.9910-15-ming.lei@redhat.com> (raw)
In-Reply-To: <20181115085306.9910-1-ming.lei@redhat.com>

This patch pulls the trigger for multi-page bvecs.

Now any request queue which supports queue cluster will see multi-page
bvecs.

Cc: Dave Chinner <dchinner@redhat.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel at redhat.com
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel at vger.kernel.org
Cc: Shaohua Li <shli@kernel.org>
Cc: linux-raid at vger.kernel.org
Cc: linux-erofs at lists.ozlabs.org
Cc: David Sterba <dsterba@suse.com>
Cc: linux-btrfs at vger.kernel.org
Cc: Darrick J. Wong <darrick.wong@oracle.com>
Cc: linux-xfs at vger.kernel.org
Cc: Gao Xiang <gaoxiang25@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4 at vger.kernel.org
Cc: Coly Li <colyli@suse.de>
Cc: linux-bcache at vger.kernel.org
Cc: Boaz Harrosh <ooo@electrozaur.com>
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: cluster-devel at redhat.com
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 block/bio.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/block/bio.c b/block/bio.c
index 6486722d4d4b..ed6df6f8e63d 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -767,12 +767,24 @@ bool __bio_try_merge_page(struct bio *bio, struct page *page,
 
 	if (bio->bi_vcnt > 0) {
 		struct bio_vec *bv = &bio->bi_io_vec[bio->bi_vcnt - 1];
-
-		if (page == bv->bv_page && off == bv->bv_offset + bv->bv_len) {
-			bv->bv_len += len;
-			bio->bi_iter.bi_size += len;
-			return true;
-		}
+		struct request_queue *q = NULL;
+
+		if (page == bv->bv_page && off == (bv->bv_offset + bv->bv_len)
+				&& (off + len) <= PAGE_SIZE)
+			goto merge;
+
+		if (bio->bi_disk)
+			q = bio->bi_disk->queue;
+
+		/* disable multi-page bvec too if cluster isn't enabled */
+		if (!q || !blk_queue_cluster(q) ||
+		    ((page_to_phys(bv->bv_page) + bv->bv_offset + bv->bv_len) !=
+		     (page_to_phys(page) + off)))
+			return false;
+ merge:
+		bv->bv_len += len;
+		bio->bi_iter.bi_size += len;
+		return true;
 	}
 	return false;
 }
-- 
2.9.5



  parent reply	other threads:[~2018-11-15  8:53 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  8:52 [Cluster-devel] [PATCH V10 00/19] block: support multi-page bvec Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 01/19] block: introduce multi-page page bvec helpers Ming Lei
2018-11-15 18:25   ` Omar Sandoval
2018-11-19  2:25     ` Ming Lei
2018-11-16 13:13   ` Christoph Hellwig
2018-11-19  2:23     ` Ming Lei
2018-11-19  3:10       ` Jens Axboe
2018-11-19  3:35         ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 02/19] block: introduce bio_for_each_bvec() Ming Lei
2018-11-15 18:28   ` Omar Sandoval
2018-11-16 13:30   ` Christoph Hellwig
2018-11-19  3:31     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 03/19] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-15 20:20   ` Omar Sandoval
2018-11-15 21:05     ` Mike Snitzer
2018-11-15 22:18       ` Omar Sandoval
2018-11-16  9:19         ` Christoph Hellwig
2018-11-16  9:41           ` Gao Xiang
2018-11-16 16:04           ` Omar Sandoval
2018-11-19  7:50     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 04/19] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-15 22:33   ` Omar Sandoval
2018-11-16 13:33   ` Christoph Hellwig
2018-11-19  7:51     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 05/19] block: introduce bvec_last_segment() Ming Lei
2018-11-15 23:23   ` Omar Sandoval
2018-11-19  7:57     ` Ming Lei
2018-11-16 13:34   ` Christoph Hellwig
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 06/19] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-16  0:20   ` Omar Sandoval
2018-11-16 13:36   ` Christoph Hellwig
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 07/19] btrfs: use bvec_last_segment to get bio's last page Ming Lei
2018-11-16  0:21   ` Omar Sandoval
2018-11-16 13:37   ` Christoph Hellwig
2018-11-19  8:09     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 08/19] btrfs: move bio_pages_all() to btrfs Ming Lei
2018-11-16  0:23   ` Omar Sandoval
2018-11-19  8:15     ` Ming Lei
2018-11-16 13:38   ` Christoph Hellwig
2018-11-19  8:19     ` Ming Lei
2018-11-19  8:24       ` Christoph Hellwig
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 09/19] block: introduce bio_bvecs() Ming Lei
2018-11-16  0:26   ` Omar Sandoval
2018-11-16 13:45   ` Christoph Hellwig
2018-11-19  8:21     ` Ming Lei
2018-11-20  0:49     ` Sagi Grimberg
2018-11-20 16:16       ` Christoph Hellwig
2018-11-20 20:11         ` Sagi Grimberg
2018-11-21  0:59           ` Ming Lei
2018-11-21  3:20             ` Sagi Grimberg
2018-11-21  3:44               ` Ming Lei
2018-11-21  4:25                 ` Sagi Grimberg
2018-11-21  4:42                   ` Sagi Grimberg
2018-11-21  5:04                     ` Ming Lei
2018-11-21  5:35                       ` Sagi Grimberg
2018-11-21  8:46                         ` Christoph Hellwig
2018-11-21 10:19                         ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 10/19] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-16  0:40   ` Omar Sandoval
2018-11-19  8:25     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 11/19] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-16  0:44   ` Omar Sandoval
2018-11-19  8:27     ` Ming Lei
2018-11-16 13:46   ` Christoph Hellwig
2018-11-19  8:28     ` Ming Lei
2018-11-15  8:52 ` [Cluster-devel] [PATCH V10 12/19] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-15 12:42   ` David Sterba
2018-11-19  8:29     ` Ming Lei
2018-11-16  1:22   ` Omar Sandoval
2018-11-19  8:32     ` Ming Lei
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 13/19] iomap & xfs: only account for new added page Ming Lei
2018-11-16  1:46   ` Omar Sandoval
2018-11-19  8:35     ` Ming Lei
2018-11-16 13:49   ` Christoph Hellwig
2018-11-19  8:39     ` Ming Lei
2018-11-15  8:53 ` Ming Lei [this message]
2018-11-16  1:56   ` [Cluster-devel] [PATCH V10 14/19] block: enable multipage bvecs Omar Sandoval
2018-11-19  8:45     ` Ming Lei
2018-11-16 13:53   ` Christoph Hellwig
2018-11-19  9:00     ` Ming Lei
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 15/19] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-16  1:59   ` Omar Sandoval
2018-11-19  9:04     ` Ming Lei
2018-11-20  2:45       ` Huang, Ying
2018-11-16 13:53   ` Christoph Hellwig
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 16/19] block: document usage of bio iterator helpers Ming Lei
2018-11-16  2:05   ` Omar Sandoval
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 17/19] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-16  2:11   ` Omar Sandoval
2018-11-19  9:06     ` Ming Lei
2018-11-16 13:55   ` Christoph Hellwig
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 18/19] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-16  2:18   ` Omar Sandoval
2018-11-16 13:59     ` Christoph Hellwig
2018-11-16 16:40       ` Omar Sandoval
2018-11-19  9:17     ` Ming Lei
2018-11-16 13:58   ` Christoph Hellwig
2018-11-19  9:20     ` Ming Lei
2018-11-15  8:53 ` [Cluster-devel] [PATCH V10 19/19] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-16 13:59   ` Christoph Hellwig
2018-11-16 16:40   ` Omar Sandoval
2018-11-16 14:03 ` [Cluster-devel] [PATCH V10 00/19] block: support multi-page bvec Christoph Hellwig
2018-11-17  2:42   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181115085306.9910-15-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).