* [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ?
@ 2018-11-15 6:49 Vasily Averin
2018-11-15 18:22 ` David Teigland
0 siblings, 1 reply; 2+ messages in thread
From: Vasily Averin @ 2018-11-15 6:49 UTC (permalink / raw)
To: cluster-devel.redhat.com
Dear David,
I've noticed that release_lockspace() lacks idr_destroy(&ls->ls_recover_idr),
though it is called on rollback in new_lockspace().
It seems for me it is not critical, and should not lead to any leaks,
however could you please re-check it?
Thank you,
Vasily Averin
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ?
2018-11-15 6:49 [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ? Vasily Averin
@ 2018-11-15 18:22 ` David Teigland
0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2018-11-15 18:22 UTC (permalink / raw)
To: cluster-devel.redhat.com
On Thu, Nov 15, 2018 at 09:49:17AM +0300, Vasily Averin wrote:
> Dear David,
> I've noticed that release_lockspace() lacks idr_destroy(&ls->ls_recover_idr),
> though it is called on rollback in new_lockspace().
>
> It seems for me it is not critical, and should not lead to any leaks,
> however could you please re-check it?
>
> Thank you,
> Vasily Averin
Thanks for the patches, I've pushed them to linux-dlm next, and added
another for the missing idr_destroy.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-15 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-15 6:49 [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ? Vasily Averin
2018-11-15 18:22 ` David Teigland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).