From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Date: Thu, 15 Nov 2018 12:22:59 -0600 Subject: [Cluster-devel] lost idr_destroy for ls_recover_idr in release_lockspace() ? In-Reply-To: <702f661c-7227-7c2e-ade5-c4d40d5862f2@virtuozzo.com> References: <702f661c-7227-7c2e-ade5-c4d40d5862f2@virtuozzo.com> Message-ID: <20181115182259.GC18025@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 15, 2018 at 09:49:17AM +0300, Vasily Averin wrote: > Dear David, > I've noticed that release_lockspace() lacks idr_destroy(&ls->ls_recover_idr), > though it is called on rollback in new_lockspace(). > > It seems for me it is not critical, and should not lead to any leaks, > however could you please re-check it? > > Thank you, > Vasily Averin Thanks for the patches, I've pushed them to linux-dlm next, and added another for the missing idr_destroy. Dave