From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 21 Nov 2018 17:08:11 +0100 Subject: [Cluster-devel] [PATCH V11 02/19] block: introduce multi-page bvec helpers In-Reply-To: <20181121150610.GA19111@ming.t460p> References: <20181121032327.8434-1-ming.lei@redhat.com> <20181121032327.8434-3-ming.lei@redhat.com> <20181121131928.GA1640@lst.de> <20181121150610.GA19111@ming.t460p> Message-ID: <20181121160811.GA4977@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Nov 21, 2018 at 11:06:11PM +0800, Ming Lei wrote: > bvec_iter_* is used for single-page bvec in current linus tree, and there are > lots of users now: > > [linux]$ git grep -n "bvec_iter_*" ./ | wc > 191 995 13242 > > If we have to switch it first, it can be a big change, just wondering if Jens > is happy with that? Your above grep statement seems to catch every use of struct bvec_iter, due to the *. Most uses of bvec_iter_ are either in the block headers, or are ceph wrappers that match the above and can easily be redefined.