From: Omar Sandoval <osandov@osandov.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH V12 17/20] block: always define BIO_MAX_PAGES as 256
Date: Mon, 26 Nov 2018 14:44:39 -0800 [thread overview]
Message-ID: <20181126224439.GN30411@vader> (raw)
In-Reply-To: <20181126021720.19471-18-ming.lei@redhat.com>
On Mon, Nov 26, 2018 at 10:17:17AM +0800, Ming Lei wrote:
> Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to
> increase BIO_MAX_PAGES for it.
>
> CONFIG_THP_SWAP needs to split one THP into normal pages and adds
> them all to one bio. With multipage-bvec, it just takes one bvec to
> hold them all.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> include/linux/bio.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index 5505f74aef8b..7be48c55b14a 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -34,15 +34,7 @@
> #define BIO_BUG_ON
> #endif
>
> -#ifdef CONFIG_THP_SWAP
> -#if HPAGE_PMD_NR > 256
> -#define BIO_MAX_PAGES HPAGE_PMD_NR
> -#else
> #define BIO_MAX_PAGES 256
> -#endif
> -#else
> -#define BIO_MAX_PAGES 256
> -#endif
>
> #define bio_prio(bio) (bio)->bi_ioprio
> #define bio_set_prio(bio, prio) ((bio)->bi_ioprio = prio)
> --
> 2.9.5
>
next prev parent reply other threads:[~2018-11-26 22:44 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 2:17 [Cluster-devel] [PATCH V12 00/20] block: support multi-page bvec Ming Lei
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 01/20] btrfs: remove various bio_offset arguments Ming Lei
2018-11-26 22:28 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 02/20] btrfs: look at bi_size for repair decisions Ming Lei
2018-11-26 22:46 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 03/20] block: remove the "cluster" flag Ming Lei
2018-11-26 22:12 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 04/20] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2018-11-26 22:14 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 05/20] block: remove bvec_iter_rewind() Ming Lei
2018-11-26 12:53 ` Christoph Hellwig
2018-11-26 22:16 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 06/20] block: rename bvec helpers Ming Lei
2018-11-26 8:17 ` Miguel Ojeda
2018-11-26 12:54 ` Christoph Hellwig
2018-11-26 22:18 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 07/20] block: introduce multi-page " Ming Lei
2018-11-26 12:55 ` Christoph Hellwig
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 08/20] block: introduce bio_for_each_bvec() and rq_for_each_bvec() Ming Lei
2018-11-26 12:55 ` Christoph Hellwig
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 09/20] block: use bio_for_each_bvec() to compute multi-page bvec count Ming Lei
2018-11-26 13:11 ` Christoph Hellwig
2018-11-26 22:37 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 10/20] block: use bio_for_each_bvec() to map sg Ming Lei
2018-11-26 13:11 ` Christoph Hellwig
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 11/20] block: introduce bvec_last_segment() Ming Lei
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 12/20] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 13/20] block: loop: pass multi-page bvec to iov_iter Ming Lei
2018-11-26 22:39 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 14/20] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2018-11-26 22:40 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 15/20] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2018-11-26 22:42 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 16/20] block: enable multipage bvecs Ming Lei
2018-11-26 12:58 ` Christoph Hellwig
2018-11-27 2:25 ` Ming Lei
2018-11-26 22:56 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 17/20] block: always define BIO_MAX_PAGES as 256 Ming Lei
2018-11-26 22:44 ` Omar Sandoval [this message]
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 18/20] block: document usage of bio iterator helpers Ming Lei
2018-11-26 12:59 ` Christoph Hellwig
2018-11-26 22:43 ` Omar Sandoval
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 19/20] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2018-11-26 2:17 ` [Cluster-devel] [PATCH V12 20/20] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2018-11-28 13:44 ` [Cluster-devel] [PATCH V12 00/20] block: support multi-page bvec Jens Axboe
2018-11-29 1:30 ` Ming Lei
2018-11-29 2:20 ` Jens Axboe
2018-11-29 3:30 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126224439.GN30411@vader \
--to=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).