From mboxrd@z Thu Jan  1 00:00:00 1970
From: PanBian <bianpan2016@163.com>
Date: Tue, 27 Nov 2018 08:40:31 +0800
Subject: [Cluster-devel] [PATCH] gfs2: get rid of potential double free
In-Reply-To: <CAHc6FU4H4y8dDhj5crjqApJAq7ZcjS+9GkE8vUK=1myk5Et2VA@mail.gmail.com>
References: <1543221809-86560-1-git-send-email-bianpan2016@163.com>
	<CAHc6FU4H4y8dDhj5crjqApJAq7ZcjS+9GkE8vUK=1myk5Et2VA@mail.gmail.com>
Message-ID: <20181127004031.GA125510@bp>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Tue, Nov 27, 2018 at 12:19:48AM +0100, Andreas Gruenbacher wrote:
> Pan,
> 
> On Mon, 26 Nov 2018 at 09:44, Pan Bian <bianpan2016@163.com> wrote:
> 
> > __gfs2_set_acl will not increase the reference count of acl if it fails.
> > In this case, posix_acl_release are called twice, one after
> > __gfs2_set_acl and one in the error handling block. This patch does not
> > release acl when __gfs2_set_acl fails.
> >
> 
> thanks for the bug report and patch; I think this should be fixed more
> clearly as in the patch I've posted earlier today.

I have seen the patch. It is really much clearer. Thank you!

Pan


> 
> Andreas