cluster-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 15/15] gfs2: log which portion of the journal is replayed
Date: Wed, 27 Feb 2019 13:55:46 -0700	[thread overview]
Message-ID: <20190227205546.26828-16-rpeterso@redhat.com> (raw)
In-Reply-To: <20190227205546.26828-1-rpeterso@redhat.com>

When a journal is replayed, gfs2 logs a message similar to:

jid=X: Replaying journal...

This patch adds the tail and block number so that the range of the
replayed block is also printed. These values will match the values
shown if the journal is dumped with gfs2_edit -p journalX. The
resulting output looks something like this:

jid=1: Replaying journal...0x28b7 to 0x2beb

This will allow us to better debug file system corruption problems.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/recovery.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index 7389e445a7a7..1012b79364a0 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -389,7 +389,8 @@ void gfs2_recover_func(struct work_struct *work)
 		}
 
 		t_tlck = ktime_get();
-		fs_info(sdp, "jid=%u: Replaying journal...\n", jd->jd_jid);
+		fs_info(sdp, "jid=%u: Replaying journal...0x%x to 0x%x\n", 
+			jd->jd_jid, head.lh_tail, head.lh_blkno);
 
 		for (pass = 0; pass < 2; pass++) {
 			lops_before_scan(jd, &head, pass);
-- 
2.20.1



      parent reply	other threads:[~2019-02-27 20:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 20:55 [Cluster-devel] [PATCH 00/15] GFS2: Withdraw corruption patches [V2] Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 01/15] gfs2: log error reform Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 02/15] gfs2: Introduce concept of a pending withdraw Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 03/15] gfs2: Ignore recovery attempts if gfs2 has io error or is withdrawn Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 04/15] gfs2: move check_journal_clean to util.c for future use Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 05/15] gfs2: Allow some glocks to be used during withdraw Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 06/15] gfs2: Make secondary withdrawers wait for first withdrawer Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 07/15] gfs2: Don't write log headers after file system withdraw Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 08/15] gfs2: Force withdraw to replay journals and wait for it to finish Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 09/15] gfs2: Add verbose option to check_journal_clean Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 10/15] gfs2: Check for log write errors before telling dlm to unlock Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 11/15] gfs2: Do log_flush in gfs2_ail_empty_gl even if ail list is empty Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 12/15] gfs2: If the journal isn't live ignore log flushes Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 13/15] gfs2: Issue revokes more intelligently Bob Peterson
2019-02-27 20:55 ` [Cluster-devel] [PATCH 14/15] gfs2: Warn when a journal replay overwrites a rgrp with buffers Bob Peterson
2019-02-27 20:55 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190227205546.26828-16-rpeterso@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).