[Cluster-devel] [PATCH v3] gfs2: Convert gfs2 to fs_context

[kbuild test robot <lkp@intel.com>]

Hi Andrew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gfs2/for-next]
[also build test ERROR on v5.1-rc2 next-20190327]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrew-Price/gfs2-Convert-gfs2-to-fs_context/20190328-005647
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next
config: i386-randconfig-x008-201912 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   fs/gfs2/ops_fstype.c: In function 'gfs2_get_tree':
>> fs/gfs2/ops_fstype.c:1217:10: error: implicit declaration of function 'vfs_get_block_super'; did you mean 'vfs_get_super'? [-Werror=implicit-function-declaration]
     error = vfs_get_block_super(fc, gfs2_fill_super);
             ^~~~~~~~~~~~~~~~~~~
             vfs_get_super
   fs/gfs2/ops_fstype.c: In function 'test_meta_super':
>> fs/gfs2/ops_fstype.c:1565:12: error: 'struct fs_context' has no member named 'bdev'
     return (fc->bdev == s->s_bdev);
               ^~
   fs/gfs2/ops_fstype.c: In function 'gfs2_meta_get_tree':
   fs/gfs2/ops_fstype.c:1585:4: error: 'struct fs_context' has no member named 'bdev'
     fc->bdev = path.dentry->d_sb->s_bdev;
       ^~
   fs/gfs2/ops_fstype.c: In function 'test_meta_super':
>> fs/gfs2/ops_fstype.c:1566:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^
   cc1: some warnings being treated as errors

vim +1217 fs/gfs2/ops_fstype.c

  1204	
  1205	/**
  1206	 * gfs2_get_tree - Get the GFS2 superblock and root directory
  1207	 * @fc: The filesystem context
  1208	 *
  1209	 * Returns: 0 or -errno on error
  1210	 */
  1211	static int gfs2_get_tree(struct fs_context *fc)
  1212	{
  1213		struct gfs2_args *args = fc->fs_private;
  1214		struct gfs2_sbd *sdp;
  1215		int error;
  1216	
> 1217		error = vfs_get_block_super(fc, gfs2_fill_super);
  1218		if (error)
  1219			return error;
  1220	
  1221		sdp = fc->root->d_sb->s_fs_info;
  1222		dput(fc->root);
  1223		if (args->ar_meta)
  1224			fc->root = dget(sdp->sd_master_dir);
  1225		else
  1226			fc->root = dget(sdp->sd_root_dir);
  1227		return 0;
  1228	}
  1229	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 30512 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20190328/793607fd/attachment.gz>