[Cluster-devel] [gfs2:for-next.glock-refcount 4/6] fs/gfs2/lops.c:873:34: sparse: symbol 'gfs2_buf_lops' was not declared. Should it be static?

[Cluster-devel] [gfs2:for-next.glock-refcount 4/6] fs/gfs2/lops.c:873:34: sparse: symbol 'gfs2_buf_lops' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git for-next.glock-refcount
head:   047f2ad3806d5222110184ae156cb83e6f603eca
commit: 159238adb2acaf65a290da8f218ded616dc77e16 [4/6] gfs2: Remove unnecessary extern declarations
reproduce:
        # apt-get install sparse
        git checkout 159238adb2acaf65a290da8f218ded616dc77e16
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   include/linux/bvec.h:166:22: sparse: expression using sizeof(void)
   include/linux/bvec.h:166:22: sparse: expression using sizeof(void)
>> fs/gfs2/lops.c:873:34: sparse: symbol 'gfs2_buf_lops' was not declared. Should it be static?
>> fs/gfs2/lops.c:882:34: sparse: symbol 'gfs2_revoke_lops' was not declared. Should it be static?
>> fs/gfs2/lops.c:891:34: sparse: symbol 'gfs2_databuf_lops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[Cluster-devel] [RFC PATCH gfs2] gfs2: gfs2_buf_lops can be static

[kbuild test robot]

Fixes: 159238adb2ac ("gfs2: Remove unnecessary extern declarations")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 lops.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index 2fd6185..6c1ec6c 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -870,7 +870,7 @@ static void databuf_lo_after_commit(struct gfs2_sbd *sdp, struct gfs2_trans *tr)
 }
 
 
-const struct gfs2_log_operations gfs2_buf_lops = {
+static const struct gfs2_log_operations gfs2_buf_lops = {
 	.lo_before_commit = buf_lo_before_commit,
 	.lo_after_commit = buf_lo_after_commit,
 	.lo_before_scan = buf_lo_before_scan,
@@ -879,7 +879,7 @@ const struct gfs2_log_operations gfs2_buf_lops = {
 	.lo_name = "buf",
 };
 
-const struct gfs2_log_operations gfs2_revoke_lops = {
+static const struct gfs2_log_operations gfs2_revoke_lops = {
 	.lo_before_commit = revoke_lo_before_commit,
 	.lo_after_commit = revoke_lo_after_commit,
 	.lo_before_scan = revoke_lo_before_scan,
@@ -888,7 +888,7 @@ const struct gfs2_log_operations gfs2_revoke_lops = {
 	.lo_name = "revoke",
 };
 
-const struct gfs2_log_operations gfs2_databuf_lops = {
+static const struct gfs2_log_operations gfs2_databuf_lops = {
 	.lo_before_commit = databuf_lo_before_commit,
 	.lo_after_commit = databuf_lo_after_commit,
 	.lo_scan_elements = databuf_lo_scan_elements,