From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h
Date: Tue, 9 Apr 2019 05:03:04 -0700 [thread overview]
Message-ID: <20190409120304.GA16296@infradead.org> (raw)
In-Reply-To: <20190409094153.3343-1-anprice@redhat.com>
On Tue, Apr 09, 2019 at 10:41:53AM +0100, Andrew Price wrote:
> Give gfs2-utils its own copy of gfs2_ondisk.h which uses userspace
> types. This allows us to always support the latest ondisk structures and
> obsoletes a lot of #ifdef GFS2_HAS_<FEATURE> blocks and configure.ac
> checks.
>
> gfs2_ondisk.h was changed simply by search-and-replace of the kernel int
> types with the uintN_t, i.e.:
>
> :%s/__u\(8\|16\|32\|64\)/uint\1_t/g
> :%s/__be\(64\|32\|16\|8\)/uint\1_t/g
>
> and the linux/types.h include replaced with stdint.h
Why? At least the be types give you really useful type checking with
sparse, which can be trivially wired up in userspace as well. Also
keeping the file 1:1 the same is going to make your life much easier
in the future..
next prev parent reply other threads:[~2019-04-09 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 9:41 [Cluster-devel] [PATCH] libgfs2: Import gfs2_ondisk.h Andrew Price
2019-04-09 12:03 ` Christoph Hellwig [this message]
2019-04-09 12:18 ` Andrew Price
2019-04-09 12:21 ` Steven Whitehouse
2019-04-09 12:35 ` Christoph Hellwig
2019-11-08 9:50 ` Andrew Price
2019-04-09 12:48 ` Andrew Price
2019-04-09 13:03 ` Steven Whitehouse
2019-04-09 13:14 ` Andrew Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409120304.GA16296@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).