From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 25 Apr 2019 09:59:33 +0200 Subject: [Cluster-devel] [PATCH 1/2] iomap: Add a page_prepare callback In-Reply-To: <20190424171804.4305-1-agruenba@redhat.com> References: <20190424171804.4305-1-agruenba@redhat.com> Message-ID: <20190425075933.GA9374@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Apr 24, 2019 at 07:18:03PM +0200, Andreas Gruenbacher wrote: > Add a page_prepare calback that's called before a page is written to. This > will be used by gfs2 to start a transaction in page_prepare and end it in > page_done. Other filesystems that implement data journaling will require the > same kind of mechanism. This looks basically fine to me. But I think it would be nicer to add a iomap_page_ops structure so that we don't have to add more pointers directly to the iomap. We can make that struct pointer const also to avoid runtime overwriting attacks.