From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Date: Thu, 25 Apr 2019 17:03:40 +0200
Subject: [Cluster-devel] [PATCH 1/2] iomap: Add a page_prepare callback
In-Reply-To: <20190425083252.GB21215@quack2.suse.cz>
References: <20190424171804.4305-1-agruenba@redhat.com>
	<20190425083252.GB21215@quack2.suse.cz>
Message-ID: <20190425150340.GA17504@lst.de>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Thu, Apr 25, 2019 at 10:32:52AM +0200, Jan Kara wrote:
> Also just looking at the code I was wondering about the following. E.g. in
> iomap_write_end() we have code like:
> 
>         if (iomap->type == IOMAP_INLINE) {
> 		foo
> 	} else if (iomap->flags & IOMAP_F_BUFFER_HEAD) {
> 		bar
> 	} else {
> 		baz
> 	}
> 
> 	if (iomap->page_done)
> 		iomap->page_done(...);
> 
> And now something very similar is in iomap_write_begin(). So won't it be
> more natural to just mandate ->page_prepare() and ->page_done() callbacks
> and each filesystem would set it to a helper function it needs? Probably we
> could get rid of IOMAP_F_BUFFER_HEAD flag that way...

I don't want pointless indirect calls for the default, non-buffer
head case.  Also inline really is a special case independent of
what the caller could pass in as flags or callbacks.  We could try to
hide the buffer_head stuff in there, but then again I'd rather kill
that off sooner than later.