From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 26 Jun 2019 14:55:02 +0200 Subject: [Cluster-devel] [PATCH 1/2] iomap: don't mark the inode dirty in iomap_write_end In-Reply-To: <20190626120333.13310-1-agruenba@redhat.com> References: <20190626120333.13310-1-agruenba@redhat.com> Message-ID: <20190626125502.GB4744@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jun 26, 2019 at 02:03:32PM +0200, Andreas Gruenbacher wrote: > Marking the inode dirty for each page copied into the page cache can be > very inefficient for file systems that use the VFS dirty inode tracking, > and is completely pointless for those that don't use the VFS dirty inode > tracking. So instead, only set an iomap flag when changing the in-core > inode size, and open code the rest of __generic_write_end. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Andreas Gruenbacher Nitpick: a patch from you should never have me as the first signoff. Just drop it, and if you feel fancy add a 'Partially based on code from Christoph Hellwig.' sentence. Not that I care much. Otherwise looks good: Reviewed-by: Christoph Hellwig Doesn't the series also need a third patch reducing the amount of mark_inode_dirty calls as per your initial proposal?